Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Docker developers to pass a parameter to control max_tries #56

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

taboca
Copy link
Contributor

@taboca taboca commented Feb 10, 2021

Fix #52

I believe that a lot of developers are having this issue but they think it's always something else. This problem may occur in slower machines like my MacAir i5 2013.

@lnorton89
Copy link

Can we get this merged? Seems pretty silly for this to still be an issue after someone's submitted a PR fixing it.

@CodingKoopa
Copy link
Contributor

This should either be closed in favor of #43, or incorporate the documentation and address the upstream concerns that are mentioned there.

@rtritto rtritto merged commit ba15b08 into mongo-express:master Jan 7, 2024
@rtritto
Copy link
Member

rtritto commented Jan 7, 2024

Readd ME_CONFIG_CONNECT_RETRIES with 10 max_tries as default.
ME_CONFIG_CONNECT_RETRIES is removed by mistake in #70.

FYI @BlackthornYugen @CodingKoopa

tianon pushed a commit to docker-library/official-images that referenced this pull request Jan 8, 2024
martin-g pushed a commit to martin-g/docker-official-images that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_tries to be a configuration
5 participants