Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added multi-variant support #93

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Added multi-variant support #93

merged 4 commits into from
Oct 2, 2023

Conversation

LaurentGoderre
Copy link
Contributor

@LaurentGoderre LaurentGoderre commented Sep 28, 2023 •
edited
Loading

TODO

  • Update the stackbrew script
  • Reimplement version update script for multi-variant

@LaurentGoderre LaurentGoderre force-pushed the multi-variant branch 3 times, most recently from e1b7376 to f0d9157 Compare September 28, 2023 20:43
@LaurentGoderre
Copy link
Contributor Author

Result of the new bashbrew script

Maintainers: Nick Cox <nickcox1008@gmail.com> (@knickers)
GitRepo: https://github.com/mongo-express/mongo-express-docker.git
GitCommit: f0d9157c39653e52f5434455592f23ac0e9c0c8c
Tags: 1.0.0, 1.0, 1, latest, 1.0.0-18, 1.0-18, 1-18, 18, 1.0.0-18-alpine3.17, 1.0-18-alpine3.17, 1-18-alpine3.17, 
Architectures: amd64, arm64v8
GitCommit: c3cebea3955f4815c01c2a6fd2a966a4296f9760
Directory: 1.0/18-alpine3.17
Tags: 1.0.0-18-alpine3.18, 1.0-18-alpine3.18, 1-18-alpine3.18, 
Architectures: amd64, arm64v8
GitCommit: c3cebea3955f4815c01c2a6fd2a966a4296f9760
Directory: 1.0/18-alpine3.18
Tags: 1.0.0-20, 1.0-20, 1-20, 20, 1.0.0-20-alpine3.17, 1.0-20-alpine3.17, 1-20-alpine3.17, 
Architectures: amd64, arm64v8
GitCommit: c3cebea3955f4815c01c2a6fd2a966a4296f9760
Directory: 1.0/20-alpine3.17
Tags: 1.0.0-20-alpine3.18, 1.0-20-alpine3.18, 1-20-alpine3.18, 
Architectures: amd64, arm64v8
GitCommit: c3cebea3955f4815c01c2a6fd2a966a4296f9760
Directory: 1.0/20-alpine3.18

@LaurentGoderre LaurentGoderre marked this pull request as ready for review September 29, 2023 15:42
@LaurentGoderre
Copy link
Contributor Author

LaurentGoderre commented Sep 29, 2023 •
edited
Loading

@BlackthornYugen let me know if you want me to demo the new scripts

@BlackthornYugen
Copy link
Member

That'd be great! Would you be free for a call on discord or something this weekend?

@LaurentGoderre
Copy link
Contributor Author

@BlackthornYugen what is your availability? Im usually free after the kjds are in bed (I noticed we are in the samer timezone)

@BlackthornYugen
Copy link
Member

@BlackthornYugen what is your availability? Im usually free after the kjds are in bed (I noticed we are in the samer timezone)

I should have some time Saturday morning or maybe Sunday evening. I might be able to do something later this evening if that works.

@LaurentGoderre
Copy link
Contributor Author

I can tonight after 10 if it's not too late. It wouldn't be very long

@BlackthornYugen
Copy link
Member

I can tonight after 10 if it's not too late. It wouldn't be very long

That should work. 🙂

@BlackthornYugen
Copy link
Member

@LaurentGoderre thanks for the demo. Looks great! As discussed you said you would be able to make one more change on Monday and then we can merge. 😄

@LaurentGoderre
Copy link
Contributor Author

Yes, I have to figure out why the variant list is duplicated in some versions

@BlackthornYugen BlackthornYugen mentioned this pull request Oct 1, 2023
Merged
@LaurentGoderre
Copy link
Contributor Author

LaurentGoderre commented Oct 2, 2023 •
edited
Loading

@BlackthornYugen this is ready for final review.

BlackthornYugen
BlackthornYugen requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@BlackthornYugen BlackthornYugen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would you be able to add a short blurb to the README.md to say when to run each script?

@LaurentGoderre
Copy link
Contributor Author

Is it ok we add it to a CONTRIBUTING.md instead of readme like here https://github.com/nodejs/docker-node/blob/main/CONTRIBUTING.md.

@BlackthornYugen
Copy link
Member

Is it ok we add it to a CONTRIBUTING.md instead of readme like here https://github.com/nodejs/docker-node/blob/main/CONTRIBUTING.md.

That'd be great! Just wanted to make sure it was documented somewhere.

@LaurentGoderre
Copy link
Contributor Author

@BlackthornYugen https://github.com/mongo-express/mongo-express-docker/pull/93/files?short_path=eca12c0#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055

@BlackthornYugen BlackthornYugen mentioned this pull request Oct 2, 2023
Closed
BlackthornYugen
BlackthornYugen approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@BlackthornYugen BlackthornYugen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @LaurentGoderre!

@BlackthornYugen BlackthornYugen merged commit a375909 into mongo-express:master Oct 2, 2023
BlackthornYugen added a commit to mongo-express/docker-official-images that referenced this pull request Oct 2, 2023
@BlackthornYugen
Update mongo-express with multi-varient support
b10e8dc 
Recreated using ./generate-stackbrew-library.sh from mongo-express/mongo-express-docker#93
@LaurentGoderre LaurentGoderre deleted the multi-variant branch October 2, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosifkit yosifkit yosifkit left review comments

@BlackthornYugen BlackthornYugen BlackthornYugen approved these changes

Assignees

@LaurentGoderre LaurentGoderre

@BlackthornYugen BlackthornYugen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LaurentGoderre @BlackthornYugen @yosifkit