Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPG key check in dockerfile broken (?), removed #575

Closed
wants to merge 1 commit into from

Conversation

jotelha
Copy link

@jotelha jotelha commented May 14, 2020

Was not able to build Docker image without removing the key key check. Keyserver ha.pool.sks-keyservers.net yields No results found: No keys found.


This change is Reviewable

@bwitt
Copy link
Contributor

bwitt commented May 14, 2020

I think it's still a good idea to validate the downloaded files; I notice the newer versions e.g. https://github.com/krallin/tini/releases/tag/v0.19.0 have sha256sums we could validate instead of using gpg

@bwitt
Copy link
Contributor

bwitt commented May 15, 2020

oh actually, we could just verify the current version file now via sha256sum with a hardcoded sha256 instead of gpg e.g.

&& echo '<output of sha256sum> /usr/local/bin/tini' | sha256sum --check 

@dungmv
Copy link

dungmv commented Oct 30, 2021

consider changing keyserver https://stackoverflow.com/questions/66217436/gpg-keyserver-receive-failed-no-name
after changing keyserver to keyserver.ubuntu.com, I was build image success

@BlackthornYugen
Copy link
Member

@jotelha #804 should have corrected this. Can you verify if the updated dockerfile works for you?

@BlackthornYugen
Copy link
Member

I'll close this for now. If there's still an issue we can use #842 to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants