Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace reindex catch #974

Merged
merged 1 commit into from Sep 18, 2022
Merged

Replace reindex catch #974

merged 1 commit into from Sep 18, 2022

Conversation

rtritto
Copy link
Member

@rtritto rtritto commented Sep 16, 2022 •
edited

This change is Reviewable

Fix reindex catch change of #973

FYI @OOCAZ

@shakaran
Copy link
Collaborator

Would be nice add unit test for this @rtritto

@rtritto rtritto changed the title Fix reindex catch Replace reindex catch Sep 16, 2022
@rtritto
Copy link
Member Author

rtritto commented Sep 17, 2022

I did some smoke test and it's working.
How can i test the two use case (req.session with error and no error)?

BlackthornYugen
BlackthornYugen approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@BlackthornYugen BlackthornYugen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rtritto)

@shakaran shakaran added this to the 1.1 milestone Sep 18, 2022
@shakaran shakaran linked an issue Sep 18, 2022 that may be closed by this pull request
Empty CSV export vulnerability, CVE-2021-23372 #966
Closed
@shakaran shakaran merged commit 4656ec2 into master Sep 18, 2022
@shakaran shakaran deleted the fix-reindex-catch branch September 18, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakaran shakaran shakaran approved these changes

@BlackthornYugen BlackthornYugen BlackthornYugen approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Empty CSV export vulnerability, CVE-2021-23372
3 participants
@rtritto @shakaran @BlackthornYugen