Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new defaultAuthor(replace defaultMigrationAuthor) #634

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

lnu
Copy link
Contributor

@lnu lnu commented Aug 1, 2023

Issue reference

see #632

wip

Documentation PR reference

Description and context

Benefits

Possible Drawbacks

Checklist

@lnu lnu changed the title wip fix: new defaultAuthor(replace defaultMigrationAuthor) Aug 1, 2023
@dieppa
Copy link
Member

dieppa commented Aug 1, 2023

LGTM

@dieppa
Copy link
Member

dieppa commented Aug 2, 2023

Hello, thanks for the changes!. This is in draft. What do you think is missing to have it ready?

@lnu
Copy link
Contributor Author

lnu commented Aug 7, 2023

Hello, thanks for the changes!. This is in draft. What do you think is missing to have it ready?

Hi, sorry for the delay, I’m on vacation now. It’s still in draft because I did not test it, except the unit tests. If you think it’s ok, I can move it from draft.

@dieppa
Copy link
Member

dieppa commented Aug 7, 2023

No, there is no rush on this. You are the only one noting is, so we prefer merge it when you are confident.

Enjoy your holidays 😃

set the default_author globally using spring configuration property
@lnu lnu marked this pull request as ready for review August 23, 2023 09:35
@lnu lnu requested a review from dieppa as a code owner August 23, 2023 09:35
@lnu
Copy link
Contributor Author

lnu commented Aug 23, 2023

tested locally and works as expected:

  • if not set, default_author is set as before
  • if set, the value of the property is used and applied to all changelog

@dieppa
Copy link
Member

dieppa commented Aug 23, 2023

Thanks a lot. As you say, it seems it works as expected. But I will review it as soon as possible and if everything is ok, I merge it.

Thanks again!

Copy link
Member

@dieppa dieppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We'll release it in the following days.
Thanks @lnu !

@dieppa dieppa merged commit 97d6fc7 into mongock:develop Aug 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants