Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-pre-gyp support #1

Merged
merged 3 commits into from
Apr 20, 2015
Merged

node-pre-gyp support #1

merged 3 commits into from
Apr 20, 2015

Conversation

imlucas
Copy link
Contributor

@imlucas imlucas commented Apr 17, 2015

  • binaries will be built on demand for linux and windows
  • just bump the version number in package.json (e.g. npm version patch), commit+push, and appveyor and travis will test and deploy new
    prebuilt binaries as needed
  • binaries are “maybe built” via a posttest hook for minimal
    duplication in CI configs
  • binaries live on S3 behind https://bin.mongodb.org/ (all in the
    devops production environment, fully managed and maintained by them)
    which is fronted by CloudFront (CDN)
  • using mongodb-js fork of node-pre-gyp for easier tooling integration

Good to go when this appveyor build finishes for iojs: https://ci.appveyor.com/project/imlucas/bson-ext/build/1.0.34

Review on Reviewable

- binaries will be built on demand for linux and windows
- just bump the version number in package.json (e.g. `npm version
patch`), commit+push, and appveyor and travis will test and deploy new
prebuilt binaries as needed
- binaries are “maybe built” via a posttest hook for minimal
duplication in CI configs
- binaries live on S3 behind https://bin.mongodb.org/ (all in the
devops production environment, fully managed and maintained by them)
which is fronted by CloudFront (CDN)
- using mongodb-js fork of node-pre-gyp for easier tooling integration
@imlucas
Copy link
Contributor Author

imlucas commented Apr 17, 2015

fixes mongodb/js-bson#120 mongodb/js-bson#118 mongodb/js-bson#114 mongodb/js-bson#111 nodejs/node#1245 nodejs/node#1099

- use mongodb-js/node-gyp with nodejs/node-gyp#599
  for proper windows 64bit support
- get appveyor auto-deploying and testing for the full matrix
  https://ci.appveyor.com/project/imlucas/bson-ext/build/1.0.83
@christkv christkv merged commit bc1bc93 into mongodb-js:master Apr 20, 2015
@nathanpeck
Copy link
Contributor

This change has broken the bson module for me across both Ubuntu and Mac. It was working perfect before in version 0.1.0, but now bson is pulling in the new version 0.1.1 since it is requesting version ~0.1 and the BSON module is now failing with errors across both local Mac envs, and Ubuntu machines I'm working with.

@christkv
Copy link
Contributor

what error are you seeing as I cannot repro

@nathanpeck
Copy link
Contributor

Here is the root issue: https://github.com/christkv/bson-ext/issues/2

@skotchio
Copy link

It's seems I have this problem related to Automattic/mongoose#2905

@skotchio
Copy link

@nathanpeck did you resolve the issue?

@nathanpeck
Copy link
Contributor

Yes, they fixed the issue by releasing a new version of the package that didn't have a precompiled Mac OS X binary inside of it. You should be able to npm cache clean; npm rm -rf node_modules/mongoose; npm install to fix it.

@skotchio
Copy link

@nathanpeck thanks for the answer

christkv pushed a commit that referenced this pull request Apr 1, 2016
Get the upstream changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants