Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

COMPASS-3984 schema dialog count fix #8

Merged
merged 2 commits into from Dec 9, 2019

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Dec 9, 2019

Description

Listen for ipc.on('window:menu-share-schema-json') event and emit an event on the local app registry of the active tab instead of the global ipc event. In this case on the schema plugin, only the active tab will receive the local event and only one dialog will be shown.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@imlucas imlucas self-requested a review December 9, 2019 18:44
@imlucas imlucas merged commit c618ec5 into master Dec 9, 2019
@imlucas imlucas deleted the COMPASS-3984-schema-dialog-count-fix branch December 9, 2019 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants