This repository has been archived by the owner on May 17, 2021. It is now read-only.
chore: update dependencies for driver 3.4 and electron 6 COMPASS-4017 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
imlucas
added a commit
to mongodb-js/url
that referenced
this pull request
Jan 8, 2020
- `npm-check-updates -u` - `mongodb` should be dev and peer deps to fix mongodb-js/compass-connect#82
imlucas
added a commit
to mongodb-js/url
that referenced
this pull request
Jan 8, 2020
- `npm-check-updates -u` - `mongodb` should be dev and peer deps to fix mongodb-js/compass-connect#82
imlucas
added a commit
to mongodb-js/data-service
that referenced
this pull request
Jan 8, 2020
2 tasks
imlucas
added a commit
to mongodb-js/data-service
that referenced
this pull request
Jan 8, 2020
See electron/electron#17241 `nodeIntegration` now defaults to `false` so you'd just get an error message like > Uncaught ReferenceError: require is not defined
34 tasks
2 tasks
alenakhineika
suggested changes
Jan 14, 2020
|
@alenakhineika Yes, but I'm not able to reproduce keychain prompts. Let's find time to debug soon. I suspect as with other electron upgrades in the past the underlying binary is different and so we need some sort of migration to happen. Updated You can also manually remove these old entries from the Keychain. |
|
@imlucas but if the same will happen with compass users? they won't know how to get rid of these dialogs. |
No, the following PR's already in Compass handle all of the migration but the connect plugin electron does not contain the migration:
|
|
3e209b4 fixes semver.range instantiation in config/project.js |
imlucas
added a commit
to mongodb-js/compass-query-history
that referenced
this pull request
Jan 21, 2020
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Jan 22, 2020
… plugins ### compass-query-history@7 - COMPASS-3933 COMPASS-4072: Electron 6 and lodash updates mongodb-js/compass-query-history#41 - build(deps-dev): COMPASS-4098: bump electron from 6.1.7 to 7.1.9 mongodb-js/compass-query-history#47 ### compass-connect@5.3.2 - COMPASS-4104 urlencode credentials when using X509 - mongodb-js/compass-connect#82 chore: update dependencies for driver 3.4 and electron 6 COMPASS-4017
imlucas
added a commit
to mongodb-js/compass-explain-plan
that referenced
this pull request
Jan 22, 2020
- mongodb-js/data-service#167 for bionic on travis for mongodb-runner - mongodb-js/compass-connect#82 for electron@6 updates
5 tasks
imlucas
added a commit
to mongodb-js/compass-explain-plan
that referenced
this pull request
Jan 22, 2020
## Description - [x] COMPASS-4108 Add dependabot to compass dependencies in mongodb-js - [x] COMPASS-4084 Update plugin template for electron@6 - [x] COMPASS-4072 lodash ## Motivation and Context - [x] Dependency update ## Dependents - Depended on by mongodb-js/compass#1873 - mongodb-js/data-service#167 for bionic on travis for mongodb-runner - mongodb-js/compass-connect#82 for electron@6 updates ## Types of Changes - [x] Patch
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Jan 29, 2020
* COMPASS-3933: Update to Electron 6.0.11 * chore(ci): Update node version on travis and evergreen * chore: Remove unused jsfmt config Switched to prettier ages ago * hadron-build@23.0.2: ensure gnome-keyring is set as a requirement for debian OSs * COMPASS-3917: keytar 5 upgrade * build(deps): COMPASS-3933: Update to latest connect and query history plugins ### compass-query-history@7 - COMPASS-3933 COMPASS-4072: Electron 6 and lodash updates mongodb-js/compass-query-history#41 - build(deps-dev): COMPASS-4098: bump electron from 6.1.7 to 7.1.9 mongodb-js/compass-query-history#47 ### compass-connect@5.3.2 - COMPASS-4104 urlencode credentials when using X509 - mongodb-js/compass-connect#82 chore: update dependencies for driver 3.4 and electron 6 COMPASS-4017 * build(deps): COMPASS-3933 update compass-explain-plan - [x] mongodb-js/compass-explain-plan#17 - [x] mongodb-js/compass-explain-plan#33 * COMPASS-3933: Latest metrics and others * update dev deps * remove dupe deps from compass-schema * more extraneous deps * ⬆️ export to lang, crud, schema validation * latest language model * COMPASS-3933: latest agg plugin mongodb-js/compass-aggregations#120 * build(deps): source app-migrations from npm instead of github * build(deps): latest hadron* hadron-app@latest hadron-app-registry@latest hadron-compile-cache@latest hadron-document@latest hadron-module-cache@latest * build(deps): Update all mongodb* to latest - mongodb-ace-autocompleter@0.4.1 - mongodb-extended-json@1.11.0 - mongodb-connection-model@14.4.3 - mongodb-js-metrics@5.0.0 - mongodb-language-model@1.6.1 - mongodb-explain-plan-model@0.2.3 - mongodb-ace-mode@0.4.1 - mongodb@3.5.2 - mongodb-data-service@16.4.0 - mongodb-query-parser@2.0.0 - mongodb-schema@8.2.5 - mongodb-query-util@0.2.1 - mongodb-collection-model@3.1.0 - mongodb-ns@2.2.0 * COMPASS-3933: latest crud Co-authored-by: Lucas Hrabovsky <hrabovsky.lucas@gmail.com> Co-authored-by: Irina Shestak <lrlna@users.noreply.github.com>
gribnoysup
pushed a commit
to mongodb-js/compass
that referenced
this pull request
Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Electron 5 introduced a breaking change by changing the default of the
nodeIntegrationoption forBrowserWindowtofalse. This manifests in plugins as unexpected fatal error messages like7e181a1 fixes
npm startand 8fb4bf5 fixesnpm run test:karmaFurther discussion in electron/electron#17241
Todo
Manual testing per Alena's note on keychain prompts
COMPASS-3933: Update dependencies storage-mixin#21 Fix
ERROR: 'WTF', Object{err: Object{}, resp: undefined}in storage-mixin and COMPASS-3917: keytar upgradeFix travis failure for error when running karma
Motivation and Context
Types of changes