Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Fix a style issue where document-element covered partially by document action bar #283

Merged

Conversation

lukywong
Copy link
Contributor

@lukywong lukywong commented Sep 5, 2020

On readonly document, the first line objectid cannot be selected because it's covered by document action bar
image

Description

Document element's style z-index is set by 1 to make it frontward and not to be covered by document action bar

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@Anemy
Copy link
Member

Anemy commented Sep 28, 2020

Hi @lukywong thanks for the PR! Before we merge this I think I'd just like to manually test an edge case where the _id is a long string and overlaps with these actions - I think we want the actions to take precedence over the _id selection in this case.

@lukywong
Copy link
Contributor Author

lukywong commented Oct 1, 2020

Hi @Anemy, yes, the actions precedence is the first priority, so i made a small commit to fix the missing, thank you.

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This'll probably make it into the 1.24.0 compass release (1.23 is in beta currently). Thanks!

@Anemy Anemy merged commit a784e90 into mongodb-js:master Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants