fix(compass-components): calculate the maximum line length in a more …

…stack efficient way COMPASS-7647 (#5509)

fix for very many line breaks and a regression test

packages/compass-components/src/components/document-list/document.spec.tsx

@@ -28,6 +28,11 @@ describe('Document', function () {
       num: 123,
       date: new Date(0),
       null_value: null,
+      // Regression test for very large numbers of parameters passed to
+      // Math.max(). One test starts to fail at around 62535 line breaks, more
+      // after that. It depends on how much data is already on the stack at that
+      // point.
+      crazy_string: Array.from({ length: 100000 }, () => '\n').join('\n'),
     });
   });
 

packages/compass-components/src/components/document-list/element-editors.tsx

@@ -197,9 +197,13 @@ export const ValueEditor: React.FunctionComponent<{
   const inputStyle = useMemo(() => {
     if (type === 'String') {
       const lines = val.split('\n');
-      const longestLineCharLength = Math.max(
-        ...lines.map((line) => line.length)
-      );
+      let longestLineCharLength = 0;
+      for (const line of lines) {
+        const length = line.length;
+        if (length > longestLineCharLength) {
+          longestLineCharLength = length;
+        }
+      }
       const width = `${Math.min(
         // Adding one to account for a textarea resize icon button thingie
         longestLineCharLength + 1,