Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compass-shell): Show mongosh version in help panel, increase panel height, update text COMPASS-4844 #2333

Merged
merged 8 commits into from Jul 9, 2021

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Jul 7, 2021

COMPASS-4844

This PR updates compass-shell to show the mongosh version in the help panel. We also increased the height of the toolbar of this panel (28->32) and updated some of the type, removing some betas and clarifying semantic keys with uppercase.

Here's how it looks now:

new.mongosh.size.mp4

Screen Shot 2021-07-07 at 5 00 13 PM

Do we use mongoSH in a lot of places? Maybe we should update it to MongoDB Shell.

@mmarcon
Copy link
Member

mmarcon commented Jul 8, 2021

@Anemy yes, mongoSH is not really a thing. We either say mongosh or MongoDB Shell, the former being what most people probably will refer to it as and the latter being the correct product name.

@mcasimir
Copy link
Contributor

mcasimir commented Jul 8, 2021

MongoDB Shell, the former being what most people probably will refer to it as and the latter being the correct product name.

Should we use MongoDB Shell also as the panel title where we have '>_ MONGOSH' now?

@addaleax
Copy link
Contributor

addaleax commented Jul 8, 2021

MongoDB Shell, the former being what most people probably will refer to it as and the latter being the correct product name.

Should we use MongoDB Shell also as the panel title where we have '>_ MONGOSH' now?

I’d vote to keep mongosh/MONGOSH here.

@mmarcon
Copy link
Member

mmarcon commented Jul 8, 2021

I’d vote to keep mongosh/MONGOSH here.

Same.

@mcasimir mcasimir merged commit 75eea68 into main Jul 9, 2021
@mcasimir mcasimir deleted the COMPASS-4844 branch July 9, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants