feat: node.js driver with loadbalanced connections COMPASS-4898 #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasimir
force-pushed
the
temp-serverless-driver
branch
from
e37e8a5
to
4de7862
Compare
addaleax
approved these changes
Jul 9, 2021
| @@ -72,7 +72,7 @@ functions: | |||
| export NPM_CACHE_DIR="$(pwd)/.deps/.npm" | |||
| export NPM_TMP_DIR="$(pwd)/.deps/tmp" | |||
|
|
|||
| export NODE_JS_VERSION="12.4.0" | |||
| export NODE_JS_VERSION="12.9.0" | |||
There was a problem hiding this comment.
I mean, you can just make it 12.22.3 here? Doesn’t have to be the exact minimum required by the driver :)
There was a problem hiding this comment.
That's a good point! Do you know why driver needs at least 12.9.0 now? Wondering if our electron can keep up with that
There was a problem hiding this comment.
I don’t have any more context than this: mongodb/node-mongodb-native#2864 (comment)
So I think it’s fine, at least for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.