fix: build re-compile driver COMPASS-4939 #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
approved these changes
Jul 12, 2021
gribnoysup
reviewed
Jul 12, 2021
package.json
Outdated
| @@ -27,6 +27,7 @@ | |||
| "packages-version": "lerna version --allow-branch main --no-push --no-private -m \"chore(release): Bump package versions\"", | |||
| "release": "npm run release --workspace mongodb-compass --", | |||
| "release-evergreen": "npm run release-evergreen --workspace=mongodb-compass --", | |||
| "build-dist-package": "rm -Rf packages/compass/dist && DEBUG='hadron*' HADRON_SKIP_INSTALLER='true' HADRON_PRODUCT='mongodb-compass' HADRON_PRODUCT_NAME='MongoDB Compass' HADRON_DISTRIBUTION='compass' npm run release-evergreen", | |||
There was a problem hiding this comment.
This rm -rf will remove other builds in dist if you have any, might be better to avoid that maybe? Build process cleans up all the used paths itself anyway IIRC
mcasimir
commented
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
npm install --productionwe have inhadron-buildwon't compileaddaleax/node-mongodb-native#71d4c39e5c858f49d10e840df626eca4da653e28.This is a quick fix that adds an additional
npm installfor the driver if comes from a fork (just as a safeguard in case we would forget removing it)