Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add link and descriptions for the $documents stage COMPASS-5170 #2664

Merged
merged 1 commit into from
Jan 7, 2022
Merged

feat: add link and descriptions for the $documents stage COMPASS-5170 #2664

merged 1 commit into from
Jan 7, 2022

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Jan 7, 2022 •
edited

Description

Add a link to the official documentation for the $documents stage (5.1 support): https://docs.mongodb.com/v5.1/reference/operator/aggregation/documents/#mongodb-pipeline-pipe.-documents

Change the incorrect kerberosCanonicalizeHostname string type to proper boolean: https://github.com/mongodb-js/vscode/blob/VSCODE-312-switch-to-new-data-service-and-model-v2/src/views/webview-app/connection-model/legacy-connection-model.ts#L40

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Anemy
Anemy approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice

@alenakhineika alenakhineika merged commit bb13a84 into main Jan 7, 2022
@alenakhineika alenakhineika deleted the COMPASS-5170-add-documents-stage-link branch January 7, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alenakhineika @Anemy