fix(compass): move theme menu from help to view in non mac/darwin COMPASS-5390 #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Anemy
commented
Jan 7, 2022
•
Anemy
commented
Anemy
changed the title
gribnoysup
approved these changes
Jan 10, 2022
|
@gribnoysup chatted with Claudia on it before the holidays. We were seeing apps tend to have their preferences in the app menu on mac so we put theme there. I'm fine with either way. If it's alright I'll merge this and we can do a quick follow up pr if we'd like to move it all into view. |
|
No need to move it, I was just interested in the reason for that as it wasn't clear from the Slack discussion that this is what we are going to do, thanks for providing the context |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.