ci(evergreen): Split test and test-electron to separate commands #2851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a follow-up to what we discussed the other day on the stand-up and should allow us to enable Evergreen CI for PRs in Compass (and disable GitHub Actions that we currently use for PRs) aligning the CI that we run during release and when making changes to the application. To make this possible we are doing a few things in this patch:
Minimize the amount of code that needs to run on the macos codesign machine (the only one with the GUI session enabled). For that I'm splitting tests that run in electron and node runtime in separate tasks. I also did another round of normalizing how package.json scripts look in the workspaces in the monorepo. This had a side-effect of actually trying to run most of the electron karma test that we currently have in CI highlighting that most of them are broken in one way or another in CI environment. For these tests I disabled them in CI and opened a ticket for us to do a clean-up. I also completely disabled e2e tests on macos because they are currently skipped anyway, so we are just wasting codesign machine time bootstrapping the monorepo and then stopping it.
Add special
run-on-pr
tag to some tasks in the configuration. This is something that @mcasimir found and should allow us to skip certain tasks when running CI on PR. Right now only the publish step is skipped.Also now that CI is running test in different runtimes completely separately, I cleaned up all the electron-rebuild / node-rebuild scripts from all the packages, we just do only one electron-rebuild just before running
test-ci-electron
I'm running a patch to confirm that everything is still green, but have high hopes for it to pass (maybe with a few restarts for all our usual and expected flakes)
EDIT: Patch is green so this is ready to be merged