Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(evergreen): Split test and test-electron to separate commands #2851

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

gribnoysup
Copy link
Contributor

@gribnoysup gribnoysup commented Mar 1, 2022

This patch is a follow-up to what we discussed the other day on the stand-up and should allow us to enable Evergreen CI for PRs in Compass (and disable GitHub Actions that we currently use for PRs) aligning the CI that we run during release and when making changes to the application. To make this possible we are doing a few things in this patch:

  • Minimize the amount of code that needs to run on the macos codesign machine (the only one with the GUI session enabled). For that I'm splitting tests that run in electron and node runtime in separate tasks. I also did another round of normalizing how package.json scripts look in the workspaces in the monorepo. This had a side-effect of actually trying to run most of the electron karma test that we currently have in CI highlighting that most of them are broken in one way or another in CI environment. For these tests I disabled them in CI and opened a ticket for us to do a clean-up. I also completely disabled e2e tests on macos because they are currently skipped anyway, so we are just wasting codesign machine time bootstrapping the monorepo and then stopping it.

  • Add special run-on-pr tag to some tasks in the configuration. This is something that @mcasimir found and should allow us to skip certain tasks when running CI on PR. Right now only the publish step is skipped.

Also now that CI is running test in different runtimes completely separately, I cleaned up all the electron-rebuild / node-rebuild scripts from all the packages, we just do only one electron-rebuild just before running test-ci-electron

I'm running a patch to confirm that everything is still green, but have high hopes for it to pass (maybe with a few restarts for all our usual and expected flakes)

EDIT: Patch is green so this is ready to be merged

…malize related scripts in package.json files
@mcasimir mcasimir merged commit 5aa21c8 into main Mar 2, 2022
@mcasimir mcasimir deleted the split-test-and-test-electron branch March 2, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants