chore(compass-components): add TabNavBar component to compass-components COMPASS-5517 #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasimir
approved these changes
Mar 4, 2022
| <a className={classnames(styles['schema-zero-state-link'])} onClick={this.onOpenLink.bind(this)}> | ||
| Learn more about schema analysis in Compass | ||
| </a> | ||
| <Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
TabNavBarfrom hadron-react-components to compass-components. This pr makes the component listen to the theme with the other component that is added in this packageWorkspaceContainer- COMPASS-5521 . We're also reducing the global compasslessstyles previously used for various workspace views in Compass here. Lastly there's a little bit of drive by cleanup and some more thorough testing of theTabNavBarcomponent's functionality.To use Compass with the components handling theming instead of darkreader you can use the env variable
COMPASS_LG_DARKMODE. (video at bottom shows these components in darkmode)I think it's worth mentioning this is a bit of a misuse of the
TabsandTabfrom leafygreen-ui as we're losing the references between the html rolestaband thetabpanel. The reason for this is we're working around the leafygreen tab fully unmounting content when the tab isn't displayed. We keep the elements mounted here. I think we should improve it but that'll happen in a follow up pr.Open to any other names for these components or different component compositions if y'all have ideas.
containers.themed.mp4