chore(webpack-config-compass): Replace exports.webpack with custom exports key COMPASS-5724 #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ports key `exports.webpack` helped us bundle Compass from source, but at the same time it was messing with external users of published packages, specifically cloud team was having troubles with it and had to add special aliases in their webpack configuration to work around the issue Using custom main and exports keys completely avoids the issue as these will be ignored by any other webpack configuration unless explicitly specified
Anemy
approved these changes
Apr 13, 2022
|
|
gribnoysup
deleted the
compass-5724-replace-exports-webpack-with-custom-exports-key
branch
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exports.webpackhelped us bundle Compass from source, but at the same timeit was messing with external users of published packages, specifically cloud
team was having troubles with it and had to add special aliases in their webpack
configuration to work around the issue
Using custom main and exports fields completely avoids the issue as these will
be ignored by any other webpack configuration unless explicitly specified