Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aggregation-explain): show indexes COMPASS-5879 #3172

Merged
merged 4 commits into from Jun 8, 2022

Conversation

mabaasit
Copy link
Contributor

@mabaasit mabaasit commented Jun 7, 2022

fix(aggregation-explain): show indexes COMPASS-5879

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added fix and removed fix labels Jun 7, 2022
@github-actions github-actions bot added fix and removed fix labels Jun 7, 2022
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe an opportunity to add some more tests for the explain.ts module? Fine as is too.

@@ -256,16 +256,13 @@ const mapIndexesInformation = function (
return explainIndexes
.filter(x => x.index)
.map((explainIndex) => {
const index = collectionIndexes.find(
const collectionIndex = collectionIndexes.find(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we / should we test this function/module? I'm thinking it could help prevent any regressions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@mabaasit mabaasit requested a review from Anemy June 8, 2022 12:39
@mabaasit mabaasit merged commit d78f63c into main Jun 8, 2022
@mabaasit mabaasit deleted the COMPASS-5879-show-indexes branch June 8, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants