feat(bson-transpiler)!: bump bson and remove unused inputs #5410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasimir
changed the title
mcasimir
force-pushed
the
bump-bson-in-bson-transpilers
branch
from
f4e3e76
to
5c260c9
Compare
mcasimir
changed the title
mcasimir
changed the title
mcasimir
commented
Feb 15, 2024
| @@ -220,24 +220,12 @@ Templates: | |||
| CodeCodeArgsTemplate: &CodeCodeArgsTemplate null | |||
| CodeScopeTemplate: &CodeScopeTemplate null | |||
| CodeScopeArgsTemplate: &CodeScopeArgsTemplate null | |||
| ObjectIdToStringTemplate: &ObjectIdToStringTemplate !!js/function > | |||
There was a problem hiding this comment.
this was not necessary, only breaks some of the transformations that are correctly handled by default
mcasimir
commented
Feb 15, 2024
| @@ -273,50 +236,12 @@ tests: | |||
| '$id' => BSON::ObjectId('5bfeee5ffa63a31985db9e5e') | |||
| ).id | |||
| Long-methods: | |||
| - input: | |||
| shell: NumberLong(429496729601).top | |||
There was a problem hiding this comment.
this syntax is not valid anymore
kmruiz
reviewed
Feb 15, 2024
| ).to.equal(test.output[output]); | ||
| }); | ||
| } | ||
| runner: !<tag:yaml.org,2002:js/function> |- |
There was a problem hiding this comment.
I'm sorry, but what is this? Is this to have syntax highlighting?
There was a problem hiding this comment.
Ah yeah, i don't know :). I did most of the changes with a script that parsed the yaml files, changed / replaced the tests, and wrote the file back with Yaml.dump. The yaml library generated that, i'm assuming is a fancier way to write this: !!js/function
kmruiz
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bson-transpilerspythonandjavascriptas input inbson-transpilershellinput tests cases to match thejavascriptinput tests casesThe motivation for doing this is: