chore(import-export): remove production dependency on temp COMPASS-7975 #5826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
May 22, 2024
lerouxb
reviewed
May 22, 2024
| import fs from 'fs'; | ||
| import path from 'path'; | ||
| import Sinon from 'sinon'; | ||
| import type { DataService } from 'mongodb-data-service'; | ||
| import { connect } from 'mongodb-data-service'; | ||
| import AppRegistry from 'hadron-app-registry'; | ||
|
|
||
| temp.track(); |
lerouxb
reviewed
May 22, 2024
| @@ -223,7 +230,7 @@ async function loadEJSONFileAndColumns({ | |||
| // while simultaneously determining the unique set of columns in the order | |||
| // we'll have to write to the file. | |||
| const inputStream = cursor.stream(); | |||
| const filename = temp.path({ suffix: '.jsonl' }); | |||
| const filename = generateTempFilename('.jsonl'); | |||
There was a problem hiding this comment.
This package depends on temp already, why not just use that?
There was a problem hiding this comment.
it brings 1000 dependencies and has a vulnerability. I really wish the vulnerability task to create jira tickets
lerouxb
reviewed
May 22, 2024
| @@ -106,6 +105,7 @@ | |||
| "react-dom": "^17.0.2", | |||
| "sinon": "^9.2.3", | |||
| "sinon-chai": "^3.7.0", | |||
| "temp": "^0.9.4", | |||
There was a problem hiding this comment.
Makes sense. Should always have been a dev dep.
lerouxb
approved these changes
May 22, 2024
mcasimir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes