Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compass-sidebar): adds an entrypoint for shell in sidebar COMPASS-8015 #5949

Closed
wants to merge 8 commits into from

Conversation

himanshusinghs
Copy link
Contributor

@himanshusinghs himanshusinghs commented Jun 19, 2024

Description

Adds an entrypoint in the sidebar navigation for opening shell. The action item on connection navigation is still retained.

How it works?

  • When you don't have any connection the navigation item is disabled
  • When you have just one connection the navigation item will open shell for that connection
  • When you have multiple connection it will always ask which connection to open the shell in.

Open questions:

  • Should we open the shell always in a new tab? (Answered - yes)
  • Should we have something like "Remember my preference" in the select connection modal to remember which connection to open the shell in? If yes, we would be saving that as a preference so I guess this should also come up eventually in compass preferences modal?
    (Answered - We should not have something like this because it might be confusing to users when they forget such setting exist. Instead it would be better to just always ask for which connection to open the shell in, unless there is just one connection (copied from Slack))

Demo

Screen.Recording.2024-06-27.at.11.38.30.mov

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@himanshusinghs himanshusinghs marked this pull request as ready for review June 19, 2024 13:05
@himanshusinghs himanshusinghs force-pushed the COMPASS-8015-mongosh-entrypoint branch from 6aaa80d to 13e63a6 Compare June 26, 2024 13:19
@himanshusinghs himanshusinghs force-pushed the COMPASS-8015-mongosh-entrypoint branch from 13e63a6 to d740a17 Compare June 26, 2024 15:57
@himanshusinghs
Copy link
Contributor Author

Closing this as we are not going to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant