Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compass-connections-navigation): use updated reference of required props while rendering NavigationItem #5955

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

himanshusinghs
Copy link
Contributor

@himanshusinghs himanshusinghs commented Jun 20, 2024

Description

This fixes the issue about preference changes for protectConnectionStrings not getting applied to the navigation item action. But the problem is just an example it would have been an issue for any updated value of onItemAction and onItemExpand because NavigationItem was referring the value provided to it at first render.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@himanshusinghs himanshusinghs changed the title fix: use updated reference of required props while rendering NavigationItem fix(compass-connections-navigation): use updated reference of required props while rendering NavigationItem Jun 20, 2024
@github-actions github-actions bot added the fix label Jun 20, 2024
@himanshusinghs himanshusinghs added the no release notes Fix or feature not for release notes label Jun 20, 2024
@himanshusinghs himanshusinghs merged commit 8dda731 into main Jun 24, 2024
29 checks passed
@himanshusinghs himanshusinghs deleted the fix/stale-method-reference-in-navigation branch June 24, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix no release notes Fix or feature not for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants