fix(compass-sidebar): fixes the filtering behaviour for databases and collections COMPASS-8026

[himanshusinghs]

Description

This PR brings back the original filtering behaviour that was bugged in one of the recent changes. Ideally when you are filtering and the filter matches the database then all of the collections of the database must get listed (regardless of collections matching the filter or not).

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added
• I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

Dependents

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[paula-stacho]

wait, what does listed mean? we want them included, but not expanded. we've been expanding them previously and this behaviour was removed intentionally (confirmed with Ben)

[paula-stacho]

This is not a change request, more of discussion request :) I removed the behaviour intentionally to improve the search for longer lists, where including "non-matches" in the results makes it harder to spot the actual results (they might even be out of sight below all the other items). The user can still expand the filter results, so we need to include the children. But they don't need to clutter the search results.
Sorry if I failed to make that clear before!
I can see how in some scenarios the original approach might be better, so maybe we can discuss this with design again!

[himanshusinghs]

Closing this as we will do the refactor entirely