-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ConnectionScopedTelemetry COMPASS-7968 #5960
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasimir
reviewed
Jun 24, 2024
@@ -209,17 +213,21 @@ export const saveCurrentPipeline = | |||
id: savedPipeline.id, | |||
num_stages: stagesLength, | |||
editor_view_type: mapPipelineModeToEditorViewType(getState()), | |||
connectionId: connectionInfoAccess.getCurrentConnectionInfo().id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connection_id
6e8ae32
to
3304382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ConnectionScopedTelemetry
Hooks & locator combining
telemetry
andconnectionInfoAccess
, by currying theconnectionId
(fromconnectionInfoAccess
) intotrack
. They live incompass-connections
. I'd rather they live in the telemetry, and maybe even be the telemetry default, but right now that would create a circular dependency.useConnectionScopedTelemetry
withConnectionScopedTelemetry
useConnectionScopedTrackOnChange
createConnectionScopedTelemetryLocator
This covers most cases. Occasionally, the event is outside of
connectionInfoAccess
scope, and we get theconnection_id
in some other way.Telemetry strategy
From now on, events & payload have to be registered in
@mongodb-js/compass-telemetry/src/events
. This is a first small step towards having a clear telemetry strategy in the code. Small step because right now, the payload types are mostly placeholders, I am only requiringconnectionId
(where possible).Adding new events, we should define the actual payload type. For the existing events, we can port the current payload types from the code gradually or via some script (or both 😅 ). // TODO: add a task
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes