-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPASS-546 COMPASS-547: Include Linux hadron build config #715
Conversation
772bd84
to
dfaf83d
Compare
96361ac
to
d265749
Compare
Still need to test the caveat removal / COMPASS-590 to see if it works as expected on a new Ubuntu box. Will probably leave the |
@imlucas FYI this may make mongodb-js/hadron-build#57 a bit easier to understand. |
"section": "Databases" | ||
"section": "Databases", | ||
"depends": [], | ||
"suggests": ["libgnome-keyring0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be explicit, building with this depends
and suggests
change does install on a fresh Ubuntu 14.04 LTS VirtualBox and allow me to connect to the COMPASS-195 Atlas instance. Hence as expected, Compass itself has no dependency on git
which is not installed at all.
In theory it could depend on Python as that is installed in Trusty (14.04 LTS) and would be nontrivial to remove as a system dependency (however that's unlikely as Compass also works on Windows, unless we're doing some black magic over there to install or bundle Python too which I'd guess is not happening):
http://packages.ubuntu.com/trusty/python
544b338
to
50cb7cc
Compare
Dropping WIP label as this could be merged, it just doesn't make as much sense until mongodb-js/hadron-build#57 is merged and published. https://mongodb.slack.com/archives/compass-scrum/p1483582221000158 |
50cb7cc
to
c560129
Compare
Suggested by the output of: sudo yum install ./google-chrome-stable_current_x86_64.rpm And yes, it's not a cross-site-scripting thing, unfortunate coincidence in the browser world :) Suffix of (x86-64) is a general pattern from: https://web.archive.org/web/20121015124845/http://rpm.org/wiki/PackagerDocs/ArchDependencies
1. Category ~= Group, approximately, which is deprecated in Fedora 17: https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Creating_a_SPEC_file 2. Thus setting 'categories' to "Development" seems to be the most appropriate for now: https://specifications.freedesktop.org/menu-spec/latest/apa.html#main-category-registry https://github.com/unindented/electron-installer-redhat#optionscategories
description (package.json) becomes the summary (.rpm) https://github.com/unindented/electron-installer-redhat#optionsdescription https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview description is also used for the synopsis (.deb): https://github.com/unindented/electron-installer-debian#optionsdescription
categories: ["Development"] puts it in the Programming Menu which just does not look correct, Compass is a GUI first, it teaches programming MongoDB secondarily and tangentially.
They should override the default values provided by electron-installer-debian: https://github.com/unindented/electron-installer-debian/blob/e42b311/src/installer.js#L191
For easier testing on Ubuntu build boxes until a hadron-build with these changes is published.
This reverts commit f164f200e19d287496a7eddc88a8e0505ce5b449.
c560129
to
bca050f
Compare
All of these changes were incorporated into #742 |
To populate more of the pretty metadata on Ubuntu and Red Hat, and set the requires for Red Hat so it installs and runs.
Manually tested when combined with mongodb-js/hadron-build#57
Known Caveats:
COMPASS 590: Add depends and suggests
) Ubuntu should not depend ongit
andpython
https://jira.mongodb.org/browse/COMPASS-590