Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPASS-546 COMPASS-547: Include Linux hadron build config #715

Closed
wants to merge 8 commits into from

Conversation

pzrq
Copy link
Contributor

@pzrq pzrq commented Dec 23, 2016

To populate more of the pretty metadata on Ubuntu and Red Hat, and set the requires for Red Hat so it installs and runs.

Manually tested when combined with mongodb-js/hadron-build#57

Known Caveats:

screen shot 2016-12-23 at 4 44 35 pm
screen shot 2016-12-23 at 4 49 00 pm

@pzrq pzrq force-pushed the COMPASS-546-547-linux-pkg-meta branch 6 times, most recently from 772bd84 to dfaf83d Compare December 23, 2016 05:42
@pzrq pzrq force-pushed the COMPASS-546-547-linux-pkg-meta branch 2 times, most recently from 96361ac to d265749 Compare January 3, 2017 02:27
@pzrq
Copy link
Contributor Author

pzrq commented Jan 3, 2017

Still need to test the caveat removal / COMPASS-590 to see if it works as expected on a new Ubuntu box.

Will probably leave the work in progress label on this PR as it does implicitly if not explicitly depend on mongodb-js/hadron-build#57 which should be resolved first.

@pzrq
Copy link
Contributor Author

pzrq commented Jan 3, 2017

@imlucas FYI this may make mongodb-js/hadron-build#57 a bit easier to understand.

"section": "Databases"
"section": "Databases",
"depends": [],
"suggests": ["libgnome-keyring0"]
Copy link
Contributor Author

@pzrq pzrq Jan 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be explicit, building with this depends and suggests change does install on a fresh Ubuntu 14.04 LTS VirtualBox and allow me to connect to the COMPASS-195 Atlas instance. Hence as expected, Compass itself has no dependency on git which is not installed at all.

In theory it could depend on Python as that is installed in Trusty (14.04 LTS) and would be nontrivial to remove as a system dependency (however that's unlikely as Compass also works on Windows, unless we're doing some black magic over there to install or bundle Python too which I'd guess is not happening):
http://packages.ubuntu.com/trusty/python

@pzrq pzrq force-pushed the COMPASS-546-547-linux-pkg-meta branch 2 times, most recently from 544b338 to 50cb7cc Compare January 5, 2017 00:08
@pzrq
Copy link
Contributor Author

pzrq commented Jan 5, 2017

Dropping WIP label as this could be merged, it just doesn't make as much sense until mongodb-js/hadron-build#57 is merged and published. https://mongodb.slack.com/archives/compass-scrum/p1483582221000158

@pzrq pzrq force-pushed the COMPASS-546-547-linux-pkg-meta branch from 50cb7cc to c560129 Compare January 5, 2017 02:15
@imlucas imlucas self-assigned this Jan 6, 2017
Suggested by the output of:

sudo yum install ./google-chrome-stable_current_x86_64.rpm

And yes, it's not a cross-site-scripting thing, unfortunate coincidence in the browser world :)

Suffix of (x86-64) is a general pattern from:
https://web.archive.org/web/20121015124845/http://rpm.org/wiki/PackagerDocs/ArchDependencies
categories: ["Development"] puts it in the Programming Menu which just does not look correct, Compass is a GUI first, it teaches programming MongoDB secondarily and tangentially.
For easier testing on Ubuntu build boxes until a hadron-build with these changes is published.
This reverts commit f164f200e19d287496a7eddc88a8e0505ce5b449.
@imlucas
Copy link
Contributor

imlucas commented Jan 12, 2017

All of these changes were incorporated into #742

@imlucas imlucas closed this Jan 12, 2017
@pzrq pzrq deleted the COMPASS-546-547-linux-pkg-meta branch January 17, 2017 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants