-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPASS-463 action buttons disable secondary #717
COMPASS-463 action buttons disable secondary #717
Conversation
dc4360c
to
0bb394d
Compare
Still needs some kind of tooltips / message so that the user knows why the button is disabled. |
Should this be a react-tooltip? Or a 2 second toastie/error dialog possibly similar to RTSS errors? Or something fancier that the design team can help with? On the other hand once https://jira.mongodb.org/browse/COMPASS-288 is done a tooltip/message might be somewhat redundant as the replica set status would be mentioned there. |
See comments on COMPASS-463: black react-tooltip. Perhaps they can go to the side? Language something like: "Cannot <do action> on a secondary node." (replace |
something like this? @rueckstiess @fredtruman edit: I might change the text to 'This action is not available on a secondary node' |
Can you try how these changes look:
|
What Thomas said 😄 |
0bb394d
to
a559e8d
Compare
I've pushed a commit but the tooltips don't appear well next to buttons, I've had to add I've added a new css file to work with react-tooltip for these tooltips here: https://github.com/10gen/compass/blob/a559e8d5c01c49ca39336ac4d5791dc885714b2f/src/internal-packages/app/styles/secondary-tooltip.less If one of you could please look into this? @fredtruman @Sean-Oh |
Made the following changes:
|
These latest tooltips LGTM 👍 |
LGTM as well! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase, then good to go. I'll do that quickly.
265616a
to
1270d79
Compare
No description provided.