Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readonly views work in database tab. #734

Merged
merged 4 commits into from Jan 6, 2017
Merged

Readonly views work in database tab. #734

merged 4 commits into from Jan 6, 2017

Conversation

durran
Copy link
Member

@durran durran commented Jan 6, 2017

Before the database tab would not display anything if the database had readonly views. This was due to 2 reasons:

  1. The collStats command could not be executed against the system.views namespace when readonly views exist, because it is a system namespace.
  2. The collStats command failed when executing against a readonly view directly.

The mongodb-data-service 2.4.0 release filters these out instead of erroring, which is updated in this pull request. We also now format the readonly views in the table to display - instead of all zeros for values.

screen shot 2017-01-06 at 7 57 57 pm

This also now indicates in the collection view if the collection is a readonly view with a lock next to the name:

screen shot 2017-01-06 at 8 19 36 pm

@imlucas
Copy link
Contributor

imlucas commented Jan 6, 2017

Lgtm once remaining test failures resolved. Lock icon doesn't map quite right. Implies I can't access the collection because of permissions instead of the intended "this is a read only view". The fa-eye would be more traditional here.

@durran durran merged commit ca10016 into master Jan 6, 2017
@durran durran deleted the readonly-fixes branch January 6, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants