COMPASS-467 ⬆️ hadron-type-checker@0.17.1 #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it only needs an `npm install` to get the bug fix for Compass users, rather than an `npm uninstall hadron-type-checker && npm install` or some variation like `npm run clean`. Note: `npm install --production` (from https://github.com/mongodb-js/hadron-build/blob/87f4cfa/commands/release.js#L277-L281) appears to have no effect, i.e. hadron-type-checker remains at 0.17.0 if that is already installed (but that is invalid after installation too so hard to reproduce unless you already had another one lying around, for me in an Ubuntu VM). All this changes again if we switch to npm-shrinkwrap.json or yarn.lock in the long run :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it only needs an
npm installto get the bug fix for Compass users, rather than annpm uninstall hadron-type-checker && npm installor some variation likenpm run clean.Note:
npm install --production(from https://github.com/mongodb-js/hadron-build/blob/87f4cfa/commands/release.js#L277-L281) appears to have no effect, i.e. hadron-type-checker remains at 0.17.0 if that is already installed (but that is invalid after installation too so hard to reproduce unless you already had another one lying around, for me in an Ubuntu VM).All this changes again if we switch to npm-shrinkwrap.json or yarn.lock in the long run :)