Added 'clear()' to session store #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job on your first PR! 👍 I'm gonna merge because it works, but for future reference I insist on 100% test coverage for this project, so if you bring it up to 100% coverage I can release it faster :) |
vkarpov15
added a commit
that referenced
this pull request
Oct 7, 2016
|
Released in 1.3.0 🍻 |
|
Thanks @vkarpov15 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the optional methods of the session store implementation in expressjs/session. I needed this implemented for a project at work, so I thought I might contribute.
This is my first pull request ever, so there's a good chance I screwed something up. Feedback is welcome.