COMPASS-542: Build installers for Ubuntu and Redhat #45
Conversation
We can't use yarn just yet on travis until an upstream fix is landed for yarnpkg/yarn#2164
| language: node_js | ||
| node_js: | ||
| - 6 | ||
| script: npm run-script ci | ||
| cache: | ||
| # TODO (imlucas) We can't use yarn just yet on travis until an upstream | ||
| # fix is landed for https://github.com/yarnpkg/yarn/pull/2164 |
There was a problem hiding this comment.
yarnpkg/yarn#2164 appears to have been merged ~11 hours ago.
There was a problem hiding this comment.
Yes but 0.19.0 is far from being published.
| ## Auto Update | ||
|
|
||
| - `hadron-auto-update-manager`: https://github.com/hadron-auto-update-manager | ||
|
|
||
| ### macOS |
There was a problem hiding this comment.
This branch has grown large, would it be reasonable to extract the macOS / Windows / electron-prebuilt changes and get those merged independently?
| type: 'boolean', | ||
| default: true | ||
| }, | ||
| signtool_params: { |
There was a problem hiding this comment.
Is this only for electron-winstaller, or does it apply to electron-installer-codesign and/or electron-osx-sign?
There was a problem hiding this comment.
electron-winstaller only. This will be cleaned up as the refactoring to Targets instead of CONFIG makes progress.
| @@ -53,6 +136,7 @@ const toTable = (CONFIG) => { | |||
| }; | |||
|
|
|||
| exports.handler = (argv) => { | |||
| console.log('config argv', argv); | |||
There was a problem hiding this comment.
Does eslint catching these in hadron-build?
| default: pkg.author || pkg.authors | ||
| } | ||
| }; | ||
| _.assign(opts, { |
There was a problem hiding this comment.
Should we continue using _.assign over Object.assign? We tend to get warnings when installing packages, not sure if they are related:
| } | ||
| /** | ||
| * TODO (imlucas) Use pretty debian metadata and options. | ||
| * @see https://github.com/unindented/electron-installer-debian#options |
There was a problem hiding this comment.
synopsis generated from description (as our description is also <80 characters, though generally in the same style as a git commit, i.e. read until the \r\n\r\n or 79 characters, whichever comes first) would be nice here: https://www.debian.org/doc/debian-policy/ch-binary.html#s-synopsis
Have not looked at any other options though, hopefully lintian helps there.
There was a problem hiding this comment.
👍 will include in follow-up tickets.
More config refactoring e.g. `1.2.0-beta.1` -> rpm: version: 1.2.0, release: beta.1 deb: version: 1.2.0~beta.1
imlucas
changed the title
imlucas
changed the title
note
npm version majorafter merging.Todo
slugto Config class (_.dasherize('${name}-${channel suffix}')to pass toelectron-installer-debianandelectron-installer-redhat.electron-installer-debianandelectron-installer-redhatproduce wacky filenames. Figure it out and add tests to make sure they're producing the right files.error: line 2: Illegal char '-' in: Version: 1.2.0-devFollow-up tickets to create
Short-term
App icons for Linux
.icnsto a.pngset (e.g. https://iconverticons.com/online/)iconoption for allBrowserWindowanddialogcallsUser experience check for rpms (Sam)
User experience check for debs (Peter)
Codesign all linux artifacts
The notary-service already has support for
.zip,.tar.gz,.deband.rpm. Write a js api client so that thereleasecommand will produce codesigned artifacts as we do for all other platforms.https://github.com/10gen/notary-service
https://github.com/10gen/notary-service/tree/master/client
Current state of signing:
.app's. We have a special evergreen distro that has personal key on it.Get it all working on evergreen
Already a ticket for ubuntu test failure, but some additional risk in missing packages, distro availability, etc.
Backlog
Other distribution formats we may want to/have requests for:
Notes