Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!(NODE-3472): convert to Node-API #137

Merged
merged 3 commits into from
Oct 1, 2021
Merged

feat!(NODE-3472): convert to Node-API #137

merged 3 commits into from
Oct 1, 2021

Commits on Sep 22, 2021

  1. chore: address TODO for managing state through smart pointers 

    Address the TODOs asking for the state to be managed through
smart pointers and as a proper class with destructors.

This is helpful for the upcoming Node-API conversion, because
the presence of C++ exceptions in Node-API (and the fact that
Node-API support also comes with multithreading support) makes
it important to use proper C++ RAII style in order to avoid
memory leaks.
    @addaleax
    addaleax committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    a32f3a0 View commit details
    Browse the repository at this point in the history

  2. feat!(NODE-3472): convert to Node-API

    @addaleax
    addaleax committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    9df823f View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. fixup: std::move() for NewInstance

    @addaleax
    addaleax committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    bf156e9 View commit details
    Browse the repository at this point in the history