Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-6253): use runtime linking against system kerberos libraries by default #188

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix(NODE-6253): use runtime linking against system kerberos libraries by default #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edf8d86
fix(NODE-6253): use runtime linking against system kerberos libraries…
nbbeeken Jul 8, 2024
1c87111
chore: flip more flags
nbbeeken Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .evergreen/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ tasks:
commands:
- func: run tests ubuntu
vars:
GYP_DEFINES: kerberos_use_rtld=true
GYP_DEFINES: kerberos_use_rtld=false
NPM_OPTIONS: --build-from-source
- name: run-prebuild
commands:
Expand Down
6 changes: 3 additions & 3 deletions .github/scripts/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ async function parseArguments() {
const pkg = JSON.parse(await fs.readFile(resolveRoot('package.json'), 'utf8'));

const options = {
'kerberos_use_rtld': { type: 'boolean', default: false },
'kerberos_use_rtld': { type: 'boolean', default: true },
help: { short: 'h', type: 'boolean', default: false }
};

Expand Down Expand Up @@ -66,8 +66,8 @@ async function buildBindings(args, pkg) {
// it will also produce `./prebuilds/kerberos-vVERSION-napi-vNAPI_VERSION-OS-ARCH.tar.gz`.

let gypDefines = process.env.GYP_DEFINES ?? '';
if (args.kerberos_use_rtld) {
gypDefines += ' kerberos_use_rtld=true';
if (!args.kerberos_use_rtld) {
gypDefines += ' kerberos_use_rtld=false';
}

gypDefines = gypDefines.trim();
Expand Down
2 changes: 1 addition & 1 deletion binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
],
'variables': {
'ARCH': '<(host_arch)',
'kerberos_use_rtld%': 'false'
'kerberos_use_rtld%': 'true'
},
'xcode_settings': {
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
Expand Down