This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Should never killall -9
a mongod
#6
Comments
Thanks, @pzrq. I'd be happy to review any pull request from you with an alternative. |
pzrq
added a commit
that referenced
this issue
Mar 15, 2017
As per the current MongoDB docs and issue: https://docs.mongodb.com/v3.4/tutorial/manage-mongodb-processes/#use-kill #6 Just not sure about possible downstream users of this, i.e. whether anyone using mongodb-runner for instance might be relying on it in some edge case. Perhaps a major semver bump?
pzrq
added a commit
that referenced
this issue
Mar 15, 2017
As per the current MongoDB docs and issue: https://docs.mongodb.com/v3.4/tutorial/manage-mongodb-processes/#use-kill #6 Just not sure about possible downstream users of this, i.e. whether anyone using mongodb-runner for instance might be relying on it in some edge case. Perhaps a major semver bump? EDIT: Probably not, as it's only a devDependency for now so probably not as big of a deal: https://github.com/mongodb-js/runner/blob/414359f88d6f2f9d23badbbcaa6b2028f4445656/package.json#L58-L62
This should be good to close now since a PR was merged, correct? |
Yep, thanks for reminding me @addisonElliott 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What this repo does is:
https://github.com/mongodb-js/kill-mongodb/blob/15cf3f9/index.js#L7
Which is according to our docs exactly what it should not do.
Using
kill -9
(SIGKILL) basically guarantees that themongod
has no chance to trap the interrupt and do important things like flush your data to disk in a consistent (i.e. not corrupted) state.From Ruthlessly Murdering a Process:
The text was updated successfully, but these errors were encountered: