This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
require saslprep only if it is needed #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requiring saslprep adds 1s to start an application using MongoDB. This is especially painful in tests, as certain frameworks spins out multiple processes (ava, tap).
|
@mcollina We have to weigh the trade-offs of deferring the load of |
daprahamian
suggested changes
Sep 11, 2018
| _saslprep = require('saslprep'); | ||
| } catch (e) { | ||
| // don't do anything; | ||
| console.warn('Warning: no saslprep library specified. Passwords will not be sanitized'); |
There was a problem hiding this comment.
If loading _saslprep fails, can we set _saslprep to an identity function (password => password) ? That way, we only wind up console.warning once.
daprahamian
approved these changes
Sep 12, 2018
mbroadst
approved these changes
Sep 12, 2018
|
@mcollina Since reklatsmasters/saslprep#3 is resolved, do you still want to merge this in? |
|
We can close this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring saslprep adds 1s to start an application using MongoDB.
It is especially painful in tests, as certain frameworks spins out
multiple processes (ava, tap). This PR delays the load of
saslprepuntil the last possible minute.Before:
After:
(Taken with node-clinic)