fix(service-provider-core): allow specifying a host with _ characters MONGOSH-933 #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Can we add a connectivity test (e.g. docker with a host with underscore in /etc/hosts) or at least verify that if we use mongosh --host foo_bar, it fails with a dns error, i.e. it is actually passed down to the OS?
This seems like something that could very easily regress because it is invalid and so regexps that do match valid hostnames will reject this (for example, this could also be something the driver validates).
rose-m
force-pushed
the
MONGOSH-933-allow-underscore-in-host
branch
from
7bdefbb
to
ed0bad6
Compare
|
@addaleax Yeah makes a lot of sense 😅 I've added a test to check we really get a |
rose-m
force-pushed
the
MONGOSH-933-allow-underscore-in-host
branch
from
ed0bad6
to
af26598
Compare
addaleax
approved these changes
Jul 30, 2021
rose-m
force-pushed
the
MONGOSH-933-allow-underscore-in-host
branch
from
af26598
to
cbab738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.