Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-repl): ask for connection string on win32 doubleclick spawn … #1057

Merged
merged 1 commit into from Aug 11, 2021

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Aug 4, 2021

@addaleax
Copy link
Contributor Author

addaleax commented Aug 4, 2021

This is a skunkworks result, not planned work, so I think we at least need to also have a short discussion about whether we want to add this feature or not :)

Copy link
Contributor

@rose-m rose-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea of having that... brings in quite a bit of convenience IMHO 👍 👏

packages/cli-repl/test/e2e.spec.ts Show resolved Hide resolved
@Anemy
Copy link
Member

Anemy commented Aug 10, 2021

I dig it! Anything to do to get it ready to merge?

abfb1d7530b96cabf185eea.mp4

@addaleax
Copy link
Contributor Author

@Anemy Max using :SGTM: in slack for this is good enough for me :)

@addaleax addaleax merged commit d579abe into main Aug 11, 2021
@addaleax addaleax deleted the 638-dev branch August 11, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants