fix: do babel transformations for script, not module MONGOSH-986 #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tell babel that we are targeting script mode, not ES module mode. (Note that the babel docs indicate that `script` should be the default – it seems that that is not entirely accurate.) This fixes the linked bug because unlike ES modules, script mode does not automatically also enable strict mode. This also fixes a minor bug in the wrap-as-iife babel plugin, where if the input was a single string literal, escaped characters would have remained escaped (e.g., entering `'\x41'` in mongosh would have returned `\x41`, not 'A'), by keeping the existing information about the raw source instead of generating an entirely new string literal in that case.
gribnoysup
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell babel that we are targeting script mode, not ES module mode.
(Note that the babel docs indicate that
scriptshould be thedefault – it seems that that is not entirely accurate.)
This fixes the linked bug because unlike ES modules, script mode
does not automatically also enable strict mode.
This also fixes a minor bug in the wrap-as-iife babel plugin,
where if the input was a single string literal, escaped characters
would have remained escaped (e.g., entering
'\x41'in mongoshwould have returned
\x41, not 'A'), by keeping the existinginformation about the raw source instead of generating an
entirely new string literal in that case.