fix(shell-api): .watch() signature and behavior fixes MONGOSH-976 #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the `.watch()` signature so that it “officially” allows omitting the first argument. As a drive-by fix, stop applying `.tryNext()` for cases in which the change stream cursor starts from a specific point in time. (Unfortunately, `.hasNext()` is not an option here, unlike discussed with the Node.js driver team, because it is blocking like `.next()` and unlike `.tryNext()`.)
gribnoysup
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
.watch()signature so that it “officially” allowsomitting the first argument.
As a drive-by fix, stop applying
.tryNext()for cases in whichthe change stream cursor starts from a specific point in time.
(Unfortunately,
.hasNext()is not an option here, unlikediscussed with the Node.js driver team, because it is blocking
like
.next()and unlike.tryNext().)