Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): fixes autocomplete not working for db.aggregate #1412

Merged
merged 5 commits into from
Feb 20, 2023
Merged

fix(autocomplete): fixes autocomplete not working for db.aggregate #1412

merged 5 commits into from
Feb 20, 2023

Conversation

himanshusinghs
Copy link
Contributor

@himanshusinghs himanshusinghs commented Feb 20, 2023 •
edited

This PR fixes the problem with autocomplete that was earlier not working for db level aggregate (db.aggregate)

@himanshusinghs
Copy link
Contributor Author

himanshusinghs commented Feb 20, 2023 •
edited

Other issues that came to light:

  • We don't exclude first only stages while providing autocomplete for followup stages
  • We also don't exclude db namespace only stages while providing autocomplete for collection aggregation.

If those are actual issues then I can create ticket/s and return to them at some point.

@himanshusinghs himanshusinghs self-assigned this Feb 20, 2023
addaleax
addaleax approved these changes Feb 20, 2023
View reviewed changes
packages/autocomplete/src/index.ts Outdated Show resolved Hide resolved
packages/autocomplete/src/index.ts Outdated Show resolved Hide resolved
himanshusinghs and others added 2 commits February 20, 2023 12:40
@himanshusinghs @addaleax
Update packages/autocomplete/src/index.ts
aecb316 
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
@himanshusinghs @addaleax
Update packages/autocomplete/src/index.ts
548cc4d 
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
@himanshusinghs himanshusinghs mentioned this pull request Feb 20, 2023
Merged
3 tasks
@himanshusinghs
addresses PR feedback
371a848 
- for the first stage suggestions we explicitly provide stages that are
  first stage only
@himanshusinghs
documents some info about a few variables
fd1d10b
@himanshusinghs himanshusinghs merged commit ae618b7 into main Feb 20, 2023
@himanshusinghs himanshusinghs deleted the MONGOSH-1374-autocomplete-for-db-aggregate branch February 20, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees

@himanshusinghs himanshusinghs

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@himanshusinghs @addaleax