adjust telemetry names for connect event #181
Conversation
There was a problem hiding this comment.
Can we also change the event names to Title Case? Otherwise, I think Amplitude won't like them.
I think we can drop the mongosh: prefix because anyways they go into a bucket that only has mongosh events and then event names would be like Connect – or actually let's call it New Connection like in VS Code –, Update User, Help, etc.
Sorry for these annoying little tweaks.
| is_genuine: true, | ||
| non_genuine_server_name: 'mongodb', | ||
| server_arch: 'x86_64', | ||
| server_os: 'osx', | ||
| uri: ATLAS_URI |
There was a problem hiding this comment.
What does URI look like? Something like this: mongodb+srv://<credentials>@cluster0-e06dc.azure.mongodb.net/test?authSource=admin&replicaSet=Cluster0-shard-0&readPreference=primary&ssl=true? Might be PII, not sure if we can collect it.
There was a problem hiding this comment.
yes, that's what it looks like. I do not send this to telemetry though, only to user's local log file
| const log = pino({ name: 'monogsh' }, pino.destination(logDest)); | ||
| console.log(`Current sessionID: ${sessionID}`); | ||
| let userId; |
There was a problem hiding this comment.
I think this should stay userId
lrlna
force-pushed
the
rename-telemetry-events
branch
from
ae637e0
to
7d1d425
Compare
Description
As per @mmarcon's request, changing telemetry events to be snake_cased instead
of camelCased.
This PR also adds
server_osandserver_archinformation toConnectevent.