Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-repl): make --quiet the default for non-interactive usage MONGOSH-1721 #1869

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

addaleax
Copy link
Contributor

This can be disabled through --no-quiet or --verbose (although --verbose may gain other meanings in the future depending on the outcome of MONGOSH-970).

…ONGOSH-1721

This can be disabled through `--no-quiet` or `--verbose` (although
`--verbose` may gain other meanings in the future depending on the
outcome of MONGOSH-970).
@paula-stacho
Copy link
Contributor

it's a bit hard to tell for me even reading the full file 😊 - do we have a test that covers the interactive without explicit quiet=false scenario?

@addaleax
Copy link
Contributor Author

@paula-stacho Yeah, good point, we did have a test with explicit --quiet=false but it probably makes sense to just duplicate it and also cover the case where --quiet is not passed at all, did that in 9b999ac 👍

@addaleax addaleax merged commit be85eb0 into main Mar 12, 2024
57 of 61 checks passed
@addaleax addaleax deleted the 1721-dev branch March 12, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants