Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Node.js to 20.12.0 MONGOSH-1750 MONGOSH-1691 #1915

Merged
merged 6 commits into from Apr 2, 2024
Merged

Conversation

addaleax
Copy link
Contributor

@addaleax
Copy link
Contributor Author

@himanshusinghs Would it be alright to take another look at this? The patches have changed a bit, unfortunately:

And then, finally, as you know we are building on platforms that predate glibc 2.25, but Node.js broke builds for those older glibc versions by declaring that the getrandom() function in glibc would always be available (which they can do, because the official minimum is 2.28), so I:

  • Needed to add a patch to only declare the function to be available if it is at build time
  • And finally, the one I'm most unsure about, when we install Node.js from source rather than using the official binaries (i.e. exactly those old-glibc systems), I'd pin the Node.js version for that to 20.11.1. That's maybe not a great long-term solution, we could also stick to using the latest 20.x and start applying our build patches to the for-CI-only build as well

@addaleax addaleax merged commit 5b5f607 into main Apr 2, 2024
59 of 62 checks passed
@addaleax addaleax deleted the node-20-12-0 branch April 2, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants