fix(build): ensure to check spawn result and assume files unchanged MONGOSH-521 #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses a helper function to ensure spawn.sync calls throw if not successful - before lerna publish marks known changed files as assume-unchanged and reverts after publish Signed-off-by: Michael Rose <michael_rose@gmx.de>
addaleax
approved these changes
Feb 2, 2021
mcasimir
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue with our CI release pipeline is that we bump the version of the packages only in the CI environment. This leads to uncommitted changes in the git repository. The
lerna publishcommand will fail in this case and the--force-publishoption does not have any effect (see also lerna/lerna#2550).The alternative would be to do a dummy commit in the CI environment before publishing. I chose against this to at least keep consistency between the commit hash of the published package information and the tagged version. While we still knowingly have tagged versions without the package version being properly set.
This PR includes: