feat(cli-repl): add tlsCertificateSelector support on Win32 MONGOSH-573 #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
changed the title
addaleax
commented
Mar 11, 2021
| @@ -181,7 +186,8 @@ describe('e2e TLS', () => { | |||
| ); | |||
| const certUser = 'emailAddress=tester@example.com,CN=Wonderwoman,OU=DevTools Testers,O=MongoDB'; | |||
|
|
|||
| it('can connect with cert to create user', async() => { | |||
| before(async() => { | |||
| /* connect with cert to create user */ | |||
There was a problem hiding this comment.
... took me half an hour to figure out why the server couldn't find the user :)
…r support on Win32 MONGOSH-573
rose-m
approved these changes
Mar 15, 2021
| @@ -181,7 +186,8 @@ describe('e2e TLS', () => { | |||
| ); | |||
| const certUser = 'emailAddress=tester@example.com,CN=Wonderwoman,OU=DevTools Testers,O=MongoDB'; | |||
|
|
|||
| it('can connect with cert to create user', async() => { | |||
| before(async() => { | |||
| /* connect with cert to create user */ | |||
| @@ -106,9 +106,7 @@ const DEPRECATED_ARGS_WITH_REPLACEMENT: Record<string, string> = { | |||
| const UNSUPPORTED_ARGS: Readonly<string[]> = [ | |||
| 'eval', | |||
| 'sslFIPSMode', | |||
| 'tlsFIPSMode', | |||
| 'sslCertificateSelector', | |||
There was a problem hiding this comment.
We should probably update the help text of the CLI to include the flags and also add a comment in there to say that it's currently only supported on Windows.
…Selector support on Win32 MONGOSH-573
@rose-m I’ve updated the README/help output, but the flag was already documented – it should not have been, right? |
|
Yeah it should have been removed by my other PR where I cleaned those up... anyway - now looks good ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests so far (including no manual ones), and I think testing this automatically would have to involve stubbing out the
win-export-certificate-and-keypackage.