fix(node-runtime-worker-thread): Propagate child process startup errors for thread runtime #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker or child process start
gribnoysup
changed the title
addaleax
approved these changes
Mar 17, 2021
…ken characters when collecting stream chunks Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
gribnoysup
deleted the
propagate-child-process-and-worker-errors-for-thread-runtime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted by @addaleax if child process or worker thread fails to start (e.g., when you are developing a new feature), worker runtime just never resolves any requests to
evaluate. This PR fixes the issue by handling possible errors during the init state of the worker runtime and re-throwing them in the main thread so users can see them in the shell:Also spotted and fixed a tiny issue when running compass-shell in isolation locally (shakes fist at webpack)