Add --bind_ip argument to ocsp mock #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed when running the mock in Docker and using it from the host system.
mbroadst
approved these changes
Sep 1, 2020
mbroadst
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
LGTM, but this mock responder comes from the server codebase, so maybe we should have @shreyaskalyan take a look
shreyaskalyan
approved these changes
Sep 1, 2020
|
@p-mongo, can you open a server ticket to get this change merged upstream? That way we don't need to apply this patch every time we re-sync this file from the server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed when running the mock in Docker
and using it from the host system.