DRIVERS-2497 authaws and ocsp helpers #246
Conversation
Replace usage of .evergreen/auth_aws/ - activate_venv.sh with - activate-authawsvenv.sh DRIVERS-2497
For a consistent way to manage the ocsp venv DRIVERS-2497
rozza
requested review from
rcsanchez97,
kevinAlbs,
ShaneHarvey,
benjirewis and
eramongodb
There was a problem hiding this comment.
LGTM.
I had to update the shell in evergreen to explicitly use bash
As noted in DRIVERS-2497, Bash is required for the new scripts. According to documentation, the default shell used by Evergreen if not specified by a shell parameter is sh (Bourne Shell), which seems to often be confused with Bash or an alias for Bash. The fact that sh rather than bash is the default shell on Evergreen seems to be a reoccurring surprise.
I am in favor of the omission of inapplicable workarounds such as for greenlet and cryptography. I hope that they will no longer be necessary someday.
The repetition of similar script patterns across the three activate-* scripts makes me wonder if the required packages should have been specified as arguments to a common activation script, but alas.
|
Manually merged and closed. |
This PR is a followup to #236 and #244. Adds hygienic alternatives to Python virtual environment scripts for auth_aws and ocsp.
Tested against the Java driver in this patch with the following evergreen changes.
Notes
I added reviewers for all those that participated in the previous patches - please feel free to remove yourself if this PR is not relevant to you.
I had to update the shell in evergreen to explicitly use bash to get either:
. ./activate-mkstlsvenv.shand. ./activate-authawsvenv.shto work.Otherwise I got this error: