Drop support for Python 2.6 and 3.3 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajdavis
reviewed
Oct 3, 2019
| - python: 3.6 | ||
| env: TOXENV=py36-test | ||
| - python: 3.7 | ||
| env: TOXENV=py37-test | ||
| # 3.7 requires sudo: https://github.com/travis-ci/travis-ci/issues/9831 |
mockupdb/__init__.py
Outdated
| @@ -205,7 +201,7 @@ def __init__(self): | |||
|
|
|||
| def result(self, timeout=None): | |||
| self._event.wait(timeout) | |||
| # wait() always returns None in Python 2.6. | |||
| # wait() always returns None in Python 2. | |||
There was a problem hiding this comment.
Actually it returns a bool in Python 2.7. So I believe this could now be:
if not self._event.wait(timeout):
raise AssertionError('timed out waiting for Future')
There was a problem hiding this comment.
Oh you're right! I was looking at the python 3 docs which only mention 3.1 not 2.7:
Changed in version 3.1: Previously, the method always returned None.
https://docs.python.org/3/library/threading.html#threading.Event.wait
https://docs.python.org/2/library/threading.html#threading.Event.wait
ajdavis
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29.