Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-883: Fix "Create JIRA ticket" Action #82

Merged
merged 2 commits into from
Jun 21, 2023
Merged

INTMDB-883: Fix "Create JIRA ticket" Action #82

merged 2 commits into from
Jun 21, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jun 20, 2023 •
edited
Loading

Proposed changes

Jira ticket: INTMDB-883

Follow-up PR of mongodb/terraform-provider-mongodbatlas#1255

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested the CDK constructor in a CFN stack. See TESTING.md

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review June 20, 2023 07:45
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner June 20, 2023 07:45
colm-quinn
colm-quinn approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Zuhairahmed
Zuhairahmed approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but can you resolve below conflict. Otherwise LGTM

image

@andreaangiolillo andreaangiolillo merged commit 574ce66 into main Jun 21, 2023
12 checks passed
@andreaangiolillo andreaangiolillo deleted the INTMDB-883 branch June 21, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colm-quinn colm-quinn colm-quinn approved these changes

@Zuhairahmed Zuhairahmed Zuhairahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreaangiolillo @colm-quinn @Zuhairahmed